Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.11.25.00 #198962

Merged
merged 18 commits into from
Nov 27, 2024
Merged

edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.11.25.00 #198962

merged 18 commits into from
Nov 27, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 25, 2024
@carlocab
Copy link
Member

Failure looks like GuillaumeGomez/sysinfo#1392

@chenrui333 chenrui333 added the in progress Stale bot should stay away label Nov 26, 2024
@chenrui333
Copy link
Member Author

yeah, the issue got fixed with sysinfo 0.32.1, but bumping the dependency cause other build failures.

@chenrui333 chenrui333 mentioned this pull request Nov 26, 2024
Closed
@carlocab carlocab force-pushed the fb-2024.11.25.00 branch 2 times, most recently from 401f0fc to dad9534 Compare November 26, 2024 19:09
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@carlocab
Copy link
Member

@chenrui333, can you upstream the patch?

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 27, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit 0668d3f Nov 27, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the fb-2024.11.25.00 branch November 27, 2024 05:12
@chenrui333
Copy link
Member Author

@chenrui333, can you upstream the patch?

yeah, totally. 👍

@chenrui333 chenrui333 mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branchvincent branchvincent branchvincent approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenrui333 @carlocab @branchvincent @daeho-ro @BrewTestBot