Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
mysql.NewSalt()
In preparation for refactoring the auth server interface in Vitess/GMS, this change makes LateBindQueryist call
mysql.NewSalt()
directly, instead of relying on theNewSalt()
method on theMySQLDb
instance (which internally callsmysql.NewSalt()
).go-mysql-server
This fixes the test introduced in:
Related PR:
embedded.Tracer
into memTracer, to fulfil the updated interfaceI was trying to use this project
go-mysql-server
as a dependency alongside github.com/grafana/grafana-plugin-sdk-go/data. But the latter project depends on:When I updated my go modules with
go mod tidy
I started to hit a compilation error:vitess
set names binary
syntax (no quotes)syntax for:
set names binary
fails.set names 'binary'
succeeds. Seems unquoted collations in MySQL are supposed to work withset names
dolthub/dolt#8574Fixes the test introduced in:
Closed Issues
set names binary
fails.set names 'binary'
succeeds. Seems unquoted collations in MySQL are supposed to work withset names