Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk 23.0.1 #194557

Merged
merged 2 commits into from
Oct 25, 2024
Merged

openjdk 23.0.1 #194557

merged 2 commits into from
Oct 25, 2024

Conversation

calvinit
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Oct 16, 2024
@chenrui333 chenrui333 added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing labels Oct 16, 2024
This was referenced Oct 17, 2024
@calvinit
Copy link
Contributor Author

This PR needs to wait for the questdb Formula to be upgraded to version 8.1.4 before proceeding.

@calvinit calvinit mentioned this pull request Oct 24, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 24, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 24, 2024
@Bo98 Bo98 mentioned this pull request Oct 24, 2024
@fxcoudert
Copy link
Member

Incorporating the changes in #195392

@calvinit
Copy link
Contributor Author

calvinit commented Oct 25, 2024

The homepage of civl formula cannot be accessed. Can the check of this dep be skipped this time? @chenrui333

curl: (28) Failed to connect to vsl.cis.udel.edu port 443 after 75003 ms: Couldn't connect to server

Additionally, the rm -rf /Users/brew/Library/Caches/Homebrew command failed to execute due to permission problems;

rm: /Users/brew/Library/Caches/Homebrew/java_cache/.gradle/caches/modules-2: Permission denied
rm: /Users/brew/Library/Caches/Homebrew/java_cache/.gradle/caches: Permission denied
rm: /Users/brew/Library/Caches/Homebrew/java_cache/.gradle: Permission denied
rm: /Users/brew/Library/Caches/Homebrew/java_cache: Permission denied
rm: /Users/brew/Library/Caches/Homebrew: Permission denied

the public.dhe.ibm.com domain cannot be resolved.

curl: (6) Could not resolve host: public.dhe.ibm.com

It seems that there are problems with the environment of the checks.

The problems with the other two formulas, teku and tsduck, are rather strange; it's unclear if they are also environment-related. @fxcoudert

@chenrui333
Copy link
Member

The homepage of civl formula cannot be accessed. Can the check of this dep be skipped this time? @chenrui333

yeah, we should deprecate it, I will followup a bit.

@chenrui333 chenrui333 mentioned this pull request Oct 25, 2024
@chenrui333
Copy link
Member

chenrui333 commented Oct 25, 2024

for teku

it would be some license check issue

  > Task :generateLicenseReport
  Module com.github.jnr:jffi:1.3.13 has multiple license reported:
  Apache License, Version 2.0
  GNU Lesser General Public License version 3
  Consider adding module license information in overrideLicenses.
  
  Module org.jupnp:org.jupnp.support:3.0.2 has multiple license reported:
  "CDDL-1.0";link="https://opensource.org/license/cddl-1-0/";description="Common Development and Distribution License 1.0"
  CDDL-1.0
  Consider adding module license information in overrideLicenses.
  
  
  > Task :checkLicense FAILED
  > Task :ethereum:spec:compileJava
  
  FAILURE: Build failed with an exception.
  
  * What went wrong:
  Execution failed for task ':checkLicense'.
  > Some library licenses are not allowed.
    Read [/private/tmp/teku-20241025-57733-32hnk2/build/reports/licenses/dependencies-without-allowed-license.json] for more information.

for tsduck

it is the libvatek compatibility issue, upstream bug report, VisionAdvanceTechnologyInc/vatek_sdk_2#9

@chenrui333
Copy link
Member

All the issues are not related to this patch version update, merging.

@chenrui333
Copy link
Member

@calvinit thanks for the great work on this! 💯

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 25, 2024
@BrewTestBot BrewTestBot enabled auto-merge October 25, 2024 16:37
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 25, 2024
Merged via the queue into Homebrew:master with commit 016957d Oct 25, 2024
15 checks passed
@calvinit calvinit deleted the openjdk-23.0.1 branch October 28, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants