Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang 27.1 #178020

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Jul 21, 2024

Description

This updates the Erlang/OTP formula to 27.0.1.

Further considerations

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Jul 21, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 21, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 21, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the feature/erlang@27 branch 2 times, most recently from 9c5aaa0 to 201c54e Compare July 21, 2024 20:47
@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Update Erlang formula: introduce erlang@27 erlang 27.0.1 Jul 21, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the feature/erlang@27 branch 3 times, most recently from 8e8b6c3 to 175c776 Compare July 21, 2024 20:58
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the feature/erlang@27 branch 6 times, most recently from 12a7a46 to 11d586e Compare July 22, 2024 22:47
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 22, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the feature/erlang@27 branch 2 times, most recently from 5bd325e to 58fc7ed Compare July 22, 2024 22:52
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 22, 2024
@carlocab
Copy link
Member

Elixir is failing, but that seems to be due to a hard-coded assertion in the test.

Is this compatible with Erlang 27? Does it need to be rebuilt?

@NelsonVides
Copy link

Elixir is failing, but that seems to be due to a hard-coded assertion in the test.

Is this compatible with Erlang 27? Does it need to be rebuilt?

assert_match(%r{(compiled with Erlang/OTP 26)}, shell_output("#{bin}/elixir -v"))
is hardcoded to be 26 there, probably that regex can be made more flexible.

Elixir 1.17 is indeed compatible with Erlang 27: https://hexdocs.pm/elixir/1.17.3/compatibility-and-deprecations.html#between-elixir-and-erlang-otp

carlocab added a commit that referenced this pull request Sep 21, 2024
@carlocab carlocab mentioned this pull request Sep 21, 2024
6 tasks
@carlocab
Copy link
Member

Thanks; I've opened #191460. I think we can ignore the wrangler failure; wrangler no longer seems to be maintained.

@chenrui333 chenrui333 changed the title erlang 27.1 (was 27.0.1) erlang 27.1 Sep 21, 2024
@carlocab
Copy link
Member

Remaining failures should be fixed by #191459 and #191460.

@carlocab carlocab marked this pull request as ready for review September 21, 2024 18:05
@carlocab carlocab added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Sep 21, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 21, 2024
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 21, 2024
@paulo-ferraz-oliveira
Copy link
Contributor Author

This should be it. 🤞

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 21, 2024
Merged via the queue into Homebrew:master with commit a340582 Sep 21, 2024
15 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/erlang@27 branch September 21, 2024 20:47
@reneleonhardt
Copy link

reneleonhardt commented Sep 22, 2024

@paulo-ferraz-oliveira amazing work to move the world forward to Erlang 26 and 27, thank you!

Is someone checking on RabbitMQ which announced since May that they are not supporting Erlang 27 yet? 😅
https://www.rabbitmq.com/blog/2024/05/23/erlang27-support
https://www.rabbitmq.com/docs/which-erlang#erlang-27-support

Warning: Erlang 27 (released in May 2024) is currently not supported by any available RabbitMQ version. There are significant performance regressions when running RabbitMQ on Erlang 27.

https://github.com/rabbitmq/rabbitmq-server/releases/tag/v4.0.1

Erlang/OTP Compatibility Notes: This release requires Erlang 26.2.

So, can the dependency be downgraded to the new alias erlang@26 for the time being? 😄
https://github.com/Homebrew/homebrew-core/blob/master/Formula/r/rabbitmq.rb#L17

@carlocab
Copy link
Member

So, can the dependency be downgraded to the new alias erlang@26 for the time being? 😄 master/Formula/r/rabbitmq.rb#L17

Pull requests welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants