Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc 1.17.1 #1717

Closed
wants to merge 2 commits into from
Closed

pandoc 1.17.1 #1717

wants to merge 2 commits into from

Conversation

dunn
Copy link
Contributor

@dunn dunn commented Jun 5, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

cc @ilovezfs

@BrewTestBot BrewTestBot added the in progress Stale bot should stay away label Jun 5, 2016
@ilovezfs
Copy link
Contributor

ilovezfs commented Jun 5, 2016

👍

@@ -22,11 +22,6 @@ class Pandoc < Formula
depends_on "gmp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency really required here? Pandoc builds and works fine without depends_on "gmp".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's a runtime dep, according to jgm/pandoc#2943 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the reference. I haven't tried it on GNU/Linux but on Mac OS X I don't notice such an issue without installing gmp.

$ pandoc -o test.html test.md      # works on all my machines

Also, pandoc doesn't link with gmp even with depends_on "gmp" in the formula.

$ otool -L `which pandoc`
/usr/local/bin/pandoc:
    /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
    /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
    /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)

I have just now built the current version 1.17.1 without depends_on "gmp". The generated binary works fine.

Here are the logs, https://gist.github.com/d0235638893c6074fa80e906589a0232

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's give it a shot. If anything breaks we can revert. Thanks for looking closer!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a consequence of Homebrew/legacy-homebrew#39134. I'm not sure why pandoc wasn't included in Homebrew/legacy-homebrew#39709.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoff-codes Perhaps you recall?

@dunn dunn closed this in c54fdc3 Jun 5, 2016
@BrewTestBot BrewTestBot removed the in progress Stale bot should stay away label Jun 5, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants