-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pandoc 1.17.1 #1717
pandoc 1.17.1 #1717
Conversation
👍 |
@@ -22,11 +22,6 @@ class Pandoc < Formula | |||
depends_on "gmp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this dependency
really required here? Pandoc builds and works fine without depends_on "gmp"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's a runtime dep, according to jgm/pandoc#2943 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the reference. I haven't tried it on GNU/Linux but on Mac OS X I don't notice such an issue without installing gmp
.
$ pandoc -o test.html test.md # works on all my machines
Also, pandoc
doesn't link with gmp
even with depends_on "gmp"
in the formula.
$ otool -L `which pandoc`
/usr/local/bin/pandoc:
/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
/usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)
I have just now built the current version 1.17.1
without depends_on "gmp"
. The generated binary works fine.
Here are the logs, https://gist.github.com/d0235638893c6074fa80e906589a0232
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's give it a shot. If anything breaks we can revert. Thanks for looking closer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a consequence of Homebrew/legacy-homebrew#39134. I'm not sure why pandoc wasn't included in Homebrew/legacy-homebrew#39709.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoff-codes Perhaps you recall?
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?cc @ilovezfs