Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simdutf 5.0.0 #166524

Merged
merged 4 commits into from
Mar 20, 2024
Merged

simdutf 5.0.0 #166524

merged 4 commits into from
Mar 20, 2024

Conversation

Porkepix
Copy link
Contributor

Created by brew bump


Created with brew bump-formula-pr.

release notes
## What's Changed

New Features

Optimization/Performance

Fixes

New Contributors

Full Changelog: simdutf/simdutf@v4.0.9...v5.0.0

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` no Linux bottle Formula has no Linux bottle icu4c ICU use is a significant feature of the PR or issue labels Mar 18, 2024
@Porkepix
Copy link
Contributor Author

Is it normal for depends_on macos: :catalina to prevent Linux bottling and even testing?

@gromgit @chenrui333 It was introduced by dc077fc

@chenrui333
Copy link
Member

Is it normal for depends_on macos: :catalina to prevent Linux bottling and even testing?

@gromgit @chenrui333 It was introduced by dc077fc

this is the linux build run, https://github.com/Homebrew/homebrew-core/actions/runs/8332418138/job/22801580342

@Porkepix
Copy link
Contributor Author

Porkepix commented Mar 18, 2024

Is it normal for depends_on macos: :catalina to prevent Linux bottling and even testing?
@gromgit @chenrui333 It was introduced by dc077fc

this is the linux build run, Homebrew/homebrew-core/actions/runs/8332418138/job/22801580342

Duh, I missed it.
However there was no bottle, then why?

EDIT: Also I guess this can't be bumped yet: if I understand correctly, rev bump is needed due to linking, but scnlib refuses to be built using simdutf > 5

@chenrui333
Copy link
Member

  CMake Error at cmake/dependencies.cmake:64 (find_package):
    Could not find a configuration file for package "simdutf" that is
    compatible with requested version "4.0.0".
  
    The following configuration files were considered but not accepted:
  
      /opt/homebrew/lib/cmake/simdutf/simdutf-config.cmake, version: 5.0.0
      /opt/homebrew/opt/simdutf/lib/cmake/simdutf/simdutf-config.cmake, version: 5.0.0

@chenrui333
Copy link
Member

EDIT: Also I guess this can't be bumped yet: if I understand correctly, rev bump is needed due to linking, but scnlib refuses to be built using simdutf > 5

you can try patch the build to use simdutf, if still error out, report back to the upstream.

simdutf: update build and test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Mar 20, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 20, 2024
Merged via the queue into Homebrew:master with commit 2de275d Mar 20, 2024
13 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. icu4c ICU use is a significant feature of the PR or issue no Linux bottle Formula has no Linux bottle outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants