Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang_ls 0.51.0 (new formula) #165753

Merged
merged 2 commits into from
Mar 12, 2024
Merged

erlang_ls 0.51.0 (new formula) #165753

merged 2 commits into from
Mar 12, 2024

Conversation

nikitaservais
Copy link
Contributor

@nikitaservais nikitaservais commented Mar 11, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Mar 11, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@nikitaservais
Copy link
Contributor Author

nikitaservais commented Mar 11, 2024

Hello, I am sorry, but I do not understand the failed test CI / macOS 14-arm64 (pull_request). It seems to be installing the formula without the dependency, but escript is needed for the installation, and it is in the dependency erlang. Could you give me feedback?

Edit: I tested in local on M1 Pro

@SMillerDev
Copy link
Member

You defined the dependency as build-only so it's uninstalling it for runtime testing. I guess you need to add a depends_on "escript"

@chenrui333
Copy link
Member

@nikitaservais, thanks for your first contribution to homebrew-core!! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 12, 2024
@BrewTestBot BrewTestBot enabled auto-merge March 12, 2024 13:42
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 12, 2024
Merged via the queue into Homebrew:master with commit f96c5f2 Mar 12, 2024
13 checks passed
@nikitaservais nikitaservais deleted the new-formula-erlang-ls branch March 12, 2024 13:54
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants