hdf5: use CMake #157329
Closed
hdf5: use CMake #157329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI-linux-self-hosted
SMillerDev
force-pushed
the
feat/hdf5/cmake
branch
from
4db51a9 to
8e94b1b
Compare
jpfeuffer
reviewed
Jan 4, 2024
Comment on lines
-52
to
-53
| --enable-fortran | ||
| --enable-cxx |
There was a problem hiding this comment.
This is missing in your cmake config.
github-actions
bot
added
the
autosquash
jpfeuffer
reviewed
Jan 4, 2024
Formula/h/hdf5.rb
Outdated
| args << "--with-zlib=#{Formula["zlib"].opt_prefix}" if OS.linux? | ||
|
|
||
| system "./configure", *args | ||
| system "cmake", "-S", ".", "-B", "build", *std_cmake_args |
There was a problem hiding this comment.
try to add "-DCMAKE_CXX_FLAGS=-fmacro-prefix-map=$PWD=.", "-DCMAKE_C_FLAGS="-fmacro-prefix-map=$PWD=." or something similar to replace absolute paths in error messages with a dot.
jpfeuffer
reviewed
Jan 4, 2024
Co-authored-by: Julianus Pfeuffer <[email protected]>
|
Almost. Now we just need to replace the shims in the compiler wrappers which are just bash scripts. I will make a suggestion. |
jpfeuffer
reviewed
Jan 4, 2024
Co-authored-by: Julianus Pfeuffer <[email protected]>
|
Ok great. h5fc is the fortran compiler. For this, you need to enable fortran. While we are at it, we should enable c++, too, as before with autotools. |
jpfeuffer
reviewed
Jan 4, 2024
Co-authored-by: Julianus Pfeuffer <[email protected]>
jpfeuffer
reviewed
Jan 5, 2024
Co-authored-by: Julianus Pfeuffer <[email protected]>
jpfeuffer
reviewed
Jan 5, 2024
Co-authored-by: Julianus Pfeuffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Closes #157078