Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrcpy 2.3 #155523

Merged
merged 2 commits into from
Nov 26, 2023
Merged

scrcpy 2.3 #155523

merged 2 commits into from
Nov 26, 2023

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Nov 25, 2023

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.
release notes
_To receive a notification on new releases, click on **Watch > Custom > Releases** on the top._

scrcpy v2.3

Changes since v2.2:

  • Add flipped display orientation (#1380, #3819, #4441)
  • Add recording rotation (#4441)
  • Add FLAC audio codec (#4410)
  • Add raw audio (WAV) recording (20048811)
  • Fix turn screen off for Android 14 (#3927, #4456)
  • Fix camera issues on many devices (#4392)
  • Fix clipboard synchronization when no video (#4418)
  • Fix screen refresh on device rotation (7e3b9359)
  • Fix .desktop files on Linux (#4448)
  • Upgrade SDL to 2.28.5 in Windows releases
  • Various technical fixes

Highlights

Camera

Many problems related to camera capture with specific devices have been fixed.

If the new camera feature did not work on your device with scrcpy 2.2, you should definitely retry with scrcpy 2.3. (#4392)

Orientation

A new option --orientation allows to rotate or flip the video. (It replaces the deprecated --rotation option.)

It is possible to change the display orientation dynamically using shortcuts:

  • rotate display left: MOD+
  • rotate display right: MOD+
  • flip display horizontally: MOD+Shift+ or MOD+Shift+
  • flip display vertically: MOD+Shift+ or MOD+Shift+

(The two first ones already existed).

The rotation can now be applied to recording as well. For example, to capture and record a portrait video from the camera:

scrcpy --video-source=camera --camera-size=1920x1080 --orientation=90 --record=portrait.mp4

(It is not possible to apply a flip to a recorded file though, the formats and/or video players do not handle flipping as metadata, without re-encoding the video stream.)

More details in #4441 (and the documentation).

Android 14

The turn screen off feature was broken in Android 14.

It is now fixed :tada: Read some technical details.


@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` ffmpeg FFMPEG use is a significant feature of the PR or issue labels Nov 25, 2023
@chenrui333
Copy link
Member

  FAILED: app/scrcpy.p/src_cli.c.o 
  clang -Iapp/scrcpy.p -Iapp -I../app -I../app/src -I/opt/homebrew/Cellar/ffmpeg/6.0_1/include -I/opt/homebrew/include -I/opt/homebrew/include/SDL2 -I/opt/homebrew/Cellar/libusb/1.0.26/include/libusb-1.0 -fdiagnostics-color=always -DNDEBUG -Wall -Winvalid-pch -Wextra -std=c11 -O3 -Wmissing-prototypes -D_THREAD_SAFE -MD -MQ app/scrcpy.p/src_cli.c.o -MF app/scrcpy.p/src_cli.c.o.d -o app/scrcpy.p/src_cli.c.o -c ../app/src/cli.c
  ../app/src/cli.c:2158:17: error: expected expression
                  enum sc_orientation orientation;
                  ^
  ../app/src/cli.c:2159:49: error: use of undeclared identifier 'orientation'; did you mean 'rotation'?
                  if (!parse_orientation(optarg, &orientation)) {
                                                  ^~~~~~~~~~~
                                                  rotation
  ../app/src/cli.c:2123:25: note: 'rotation' declared here
                  uint8_t rotation;
                          ^
  ../app/src/cli.c:2162:45: error: use of undeclared identifier 'orientation'; did you mean 'rotation'?
                  opts->display_orientation = orientation;
                                              ^~~~~~~~~~~
                                              rotation
  ../app/src/cli.c:2123:25: note: 'rotation' declared here
                  uint8_t rotation;
                          ^
  ../app/src/cli.c:2163:44: error: use of undeclared identifier 'orientation'; did you mean 'rotation'?
                  opts->record_orientation = orientation;
                                             ^~~~~~~~~~~
                                             rotation
  ../app/src/cli.c:2123:25: note: 'rotation' declared here
                  uint8_t rotation;
                          ^
  4 errors generated.

@chenrui333 chenrui333 added the build failure CI fails while building the software label Nov 25, 2023
@rom1v
Copy link
Contributor

rom1v commented Nov 26, 2023

Fixed by Genymobile/scrcpy@4135c41 on scrcpy master branch.

Sorry for the inconvenience.

scrcpy: scrcpy-server 2.3

Signed-off-by: Rui Chen <[email protected]>
@alebcay alebcay removed the build failure CI fails while building the software label Nov 26, 2023
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 26, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 26, 2023
Merged via the queue into Homebrew:master with commit fa7e931 Nov 26, 2023
12 checks passed
@BrewTestBot BrewTestBot deleted the bump-scrcpy-2.3 branch November 26, 2023 03:42
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ffmpeg FFMPEG use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants