Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
dolt_history_
system tablesWhen filtering on an indexed column from the primary index (i.e. a pk column) if a column in the underlying table has been modified and changed its tag in previous versions, we weren't able to create the lookup builder and caused a segfault. This PR changes to use the primary index as a covering index, since it's the closest we have. This is also consistent with how we had implemented Noms range lookups.
Related to: Dolt panics querying
dolt_history_$table
dolthub/dolt#6891Unskipped a bats test I added for a join across multiple databases on tables of the same name that is now fixed.
go-mysql-server
The
View.ViewExpr
AST object seems to drop aliasing information that we depend on for query schema presentation. I want to circle back to have the view AST expression be consistent with the view definition, but this forces a re-parsing to get the correct view schema.Adding support for routines is coming, and and a bunch or string arguments is cumbersome.
Note to reviewer: start at sql/privileges.go!
In order to support procedure and function permissions, the mysql.procs_priv needs to be supported. This change add support, but gates the ability to create these grants because they are not being used for actual permission checks yet. That will come next.
I have engine tests on another branch due to the gate. I'll add them when the feature is complete. There are also bats tests in flight in the dolt repo which can be seen here:
dolthub/dolt@4d8fe2a...macneale4/privs_tests_wip
Updating from mysql.Handler changes in 7da194ad69efa0e4cc3992f860ecb92550482d62 – adding debug logging for
ComPrepare
and including params count, other minor logging cleanup.Related Vitess PR: Logging improvements dolthub/vitess#286
If a parent SubqueryAlias is marked IsLateral, then mark its child SubqueryAliases with IsLateral as well.
This essentially gives the child SubqueryAlias visibility to the left subtree all the time, which fixes the linked issue.
We should be able to differentiate between different scopes of lateral joins and only grant visibility to those columns, which could be a subset of the parent/left columns. However, I don't think we are close to getting that working.
fixes lateral recursive cte join error dolthub/dolt#6843
re: Add create view with columns dolthub/vitess#285
closes: CREATE VIEW with columns dolthub/dolt#6859
Implements index support for virtual columns, and fixes several bugs related to generated columns for certain statements.
Changes the memory table index implementation to actually store secondary indexes separately, rather than fake it via the primary index. The indexes are stored via sorted slices for now. I'll do another pass and replace them, and primary storage, with btrees for speed now that I have this proof of concept working.
Also introduces a new interface for rebuilding a single index, rather than doing a complete table rewrite every time an index is created.
vitess
ex:
We weren't walking the
With
clause for select statements, which caused us to not find any bind vars in use there.Related to: "SQLSTATE[HY093]: Invalid parameter number" with Laravel 10 dolthub/dolt#6852
Closed Issues