Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpqxx: Improve test #152521

Closed
wants to merge 1 commit into from
Closed

libpqxx: Improve test #152521

wants to merge 1 commit into from

Conversation

jviotti
Copy link
Contributor

@jviotti jviotti commented Oct 27, 2023

It seems that this libpqxx static library is somehow broken. Some basic programs, like the one currently provided in the formula, work fine, but certain components of the library seem to fail.

This PR is extending the current test to hopefully surface the error I'm seeing.

See jtv/libpqxx#739

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 27, 2023
It seems that this `libpqxx` static library is somehow broken. Some
basic programs, like the one currently provided in the formula, work
fine, but certain components of the library seem to fail.

This PR is extending the current test to hopefully surface the error I'm
seeing.

See jtv/libpqxx#739
Signed-off-by: Juan Cruz Viotti <[email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 27, 2023
@jviotti
Copy link
Contributor Author

jviotti commented Oct 27, 2023

I'm not well versed with Homebrew, but sounds like this formula should be updated to use CMake instead of Autotools, so it exports a CMake config script for find_package instead of only a pkg-config integration.

@chenrui333
Copy link
Member

I'm not well versed with Homebrew, but sounds like this formula should be updated to use CMake instead of Autotools, so it exports a CMake config script for find_package instead of only a pkg-config integration.

The only concern would be it would broke the dependencies which are using pc file (does cmake build generate pc config in the upstream)

@jviotti
Copy link
Contributor Author

jviotti commented Oct 27, 2023

@chenrui333 Looks like their CMake integration still generates the .pc file: https://github.com/jtv/libpqxx/blob/master/src/CMakeLists.txt#L88-L91

@jviotti
Copy link
Contributor Author

jviotti commented Oct 27, 2023

Hm, looks like the GitHub Actions tests are indeed passing. Weird. Can somebody check the example reproducible app I provided in the upstream bug report: jtv/libpqxx#739? Here is the direct link: https://github.com/jviotti/pqxx-test

That definitely fails for me, but only with the Homebrew formula. Building it from source actually works for me. I was expecting it to fail on CI here.

@jviotti jviotti closed this by deleting the head repository Nov 8, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants