Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio 6.1.10 #139300

Closed
Closed

Conversation

ivankravets
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Release Notes

  • Resolved an issue that caused generated projects for PlatformIO IDE for VSCode to break when the -iprefix compiler flag was used
  • Resolved an issue encountered while utilizing the pio pkg exec command on the Windows platform to execute Python scripts from a package
  • Implemented a crucial improvement to the pio run command, guaranteeing that the monitor target is not executed if any of the preceding targets, such as upload, encounter failures
  • Cppcheck v2.11 with new checks, CLI commands and various analysis improvements
  • Resolved a critical issue that arose on macOS ARM platforms due to the Python "requests" module, leading to a "ModuleNotFoundError: No module named 'chardet'" (issue #4702)

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue labels Aug 11, 2023
@chenrui333
Copy link
Member

image
@ivankravets can you follow the guide?

@ivankravets
Copy link
Contributor Author

I've been having pain with publishing PlatformIO releases to brew since the beginning. The rules changes fast and I waste a lot of time to provide PR.

How to use this system?

@ivankravets
Copy link
Contributor Author

I forgot to add. I use poetry. I remember brew recommended it for Python packages. Then I manually merge poetry output with the latest brew formula and make PR.

@chenrui333
Copy link
Member

I've been having pain with publishing PlatformIO releases to brew since the beginning. The rules changes fast and I waste a lot of time to provide PR.

How to use this system?

it is really easy, brew bump --open-pr platformio and if you want to override, you can do brew bump-open-pr platformio --version=x.x.x --force

@chenrui333
Copy link
Member

And if you want to integrate with your pipeline, you can just use these actions:

@ivankravets
Copy link
Contributor Author

brew bump --open-pr platformio
==> platformio
Current formula version:  6.1.9
Latest livecheck version: 6.1.10
Latest Repology version:  6.1.9
Open pull requests:       none
Closed pull requests:     platformio 6.1.10 (https://github.com/Homebrew/homebrew-core/pull/139300), platformio 6.1.10 (https://github.com/Homebrew/homebrew-core/pull/139295)

What is next? Has anyone tried to you this for the Python project?

@ivankravets
Copy link
Contributor Author

Does it make sense to remove platformio from the brew registry? Do you provide this option? It will save us a lot of time maintaining PlatformIO just in the PyPi registry.

@ivankravets ivankravets reopened this Aug 11, 2023
@p-linnane
Copy link
Member

p-linnane commented Aug 11, 2023

You are having issues because you need to use --force to override the closed PR. brew bump-formula-pr --version=6.1.10 platformio --force.

We do not remove projects from homebrew-core. You are not required to update it here if you do not want to. Either the community can handle it, or you can integrate one of the above listed actions as part of your release workflow.

@ivankravets
Copy link
Contributor Author

Can this PR be merged now?

@p-linnane
Copy link
Member

If you can change the commit message to be platformio 6.1.10, then yes.

@chenrui333
Copy link
Member

if you want to override, you can do brew bump-open-pr platformio --version=x.x.x --force

I thought I already mentioned this.

@chenrui333
Copy link
Member

you dont have to manually attach the release notes, just use brew bump --open-pr or brew bump-open-pr platformio --version=x.x.x

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosquash Automatically squash pull request commits according to Homebrew style. outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants