Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dive: add livecheck #135857

Closed
wants to merge 1 commit into from
Closed

dive: add livecheck #135857

wants to merge 1 commit into from

Conversation

p-linnane
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 5, 2023
@chenrui333 chenrui333 added pre-release Artifact is pre-release upstream issue An upstream issue report is needed labels Jul 5, 2023
@chenrui333
Copy link
Member

upstream release build failed, https://github.com/wagoodman/dive/actions/runs/5465690573

@chenrui333 chenrui333 mentioned this pull request Jul 6, 2023
Closed
@chenrui333
dive: add livecheck
6472432 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed pre-release Artifact is pre-release bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 7, 2023
@chenrui333 chenrui333 changed the title dive 0.10.1 dive: add livecheck Jul 7, 2023
@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jul 7, 2023
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 7, 2023
@chenrui333 chenrui333 enabled auto-merge July 7, 2023 14:51
@abitrolly
Copy link
Contributor

@chenrui333 will that also release 0.11.0?

By the way, why this PR is needed when livecheck works without it?

$ brew bump dive
...
==> dive
Current formula version:  0.10.0
Latest livecheck version: 0.11.0
Latest Repology version:  0.10.1

@chenrui333
Copy link
Member

@abitrolly it is needed whenever there is a failure release in the upstream and we might have re-tagging risk. Let me know if that makes sense, thanks!

@chenrui333
Copy link
Member

chenrui333 commented Jul 7, 2023 •
edited
Loading

@abitrolly you can also see the related issue, wagoodman/dive#456, thanks for checking on this PR.

never mind, i saw your PR, wagoodman/dive#457

@abitrolly
Copy link
Contributor

abitrolly commented Jul 7, 2023 •
edited
Loading

@abitrolly it is needed whenever there is a failure release in the upstream and we might have re-tagging risk. Let me know if that makes sense, thanks!

@chenrui333 not sure I get how it works. dive 0.10.1 got tagged, but upstream release failed. What is the re-tagging risk here? What happens if upstream get re-tagged?

@p-linnane
Copy link
Member Author

Let's just close this and bump to v0.11.0 since the release process is fixed.

@p-linnane p-linnane closed this Jul 7, 2023
auto-merge was automatically disabled July 7, 2023 18:10

Pull request was closed

@p-linnane p-linnane deleted the bump-dive-0.10.1 branch July 7, 2023 18:10
@p-linnane
Copy link
Member Author

#136077

@p-linnane p-linnane added the superseded PR was replaced by another PR label Jul 7, 2023
@chenrui333
Copy link
Member

chenrui333 commented Jul 7, 2023 •
edited
Loading

@abitrolly it is needed whenever there is a failure release in the upstream and we might have re-tagging risk. Let me know if that makes sense, thanks!

@chenrui333 not sure I get how it works. dive 0.10.1 got tagged, but upstream release failed. What is the re-tagging risk here? What happens if upstream get re-tagged?

@abitrolly this is the preventive measure that I am seeking across the board, i.e., instead of filing the upstream issues to report report about the release process issue, and get them fixed, I can just avoid running into it in the first place (by adding the livecheck to ignore the unreleased tags), let me know if that makes better sense now.

@chenrui333
Copy link
Member

Let's just close this and bump to v0.11.0 since the release process is fixed.

sure, sounds good

@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Jul 7, 2023
@chenrui333 chenrui333 removed livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jul 7, 2023
@abitrolly
Copy link
Contributor

instead of filing the upstream issues to report report about the release process issue, and get them fixed, I can just avoid running into it in the first place (by adding the livecheck to ignore the unreleased tags)

@chenrui333 that makes sense. But why brew dump dive can not ignore unreleased tags automatically?

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-linnane @chenrui333 @abitrolly