cilium-cli: fix ldflags to override correct #132507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
go
carlocab
reviewed
Jun 1, 2023
The Version var was moved and exported upstream, see cilium/cilium-cli#1646 for details. This fixes an issue when `cilium` built from Homebrew would no longer report any version in `cilium version` or `cilium sysdump`, e.g. > 🔍 Collecting sysdump with cilium-cli version: , args: [sysdump] Also add a test that verifies `cilium version` output and prefix the version with `v` like done upstream.
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Version var was moved and exported upstream, see cilium/cilium-cli#1646 for details.
This fixes an issue when
ciliumbuilt from Homebrew would no longer report any version incilium versionorcilium sysdump, e.g.Also add a test that verifies
cilium versionoutput and prefix the version withvlike done upstream.brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?