Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpine: add option for compiling with Maildir mailbox support #128

Closed
wants to merge 1 commit into from
Closed

alpine: add option for compiling with Maildir mailbox support #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Formula/alpine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,15 @@ class Alpine < Formula
sha256 "8f52d4ebe9e445ec975cabdd74c4a48cef80eebb21f18c33644e99de1a6d2173" => :mountain_lion
end

option "with-maildir", "Compile with support for Maildir format mailboxes"

depends_on "openssl"

patch do
url "http://patches.freeiz.com/alpine/patches/alpine-2.20/maildir.patch.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please submit this patch to the upstream developers of this project.Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's provided by them, so no, they already have it. They provide build options as patches. I realize that's not the way you want the world to work, so clearly we're at an impasse here. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid: See the main comments on this PR. "Patches" in this project are more like optional components, and patches.freeiz.com is upstream. Might want to include a couple of them. (We could use the resource mechanism instead, too, if the patch semantics aren't appropriate.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll begrudgingly 👍 then

sha256 "1ef0932b80d7f790ce6577a521a7b613b5ce277bb13cbaf0116bb5de1499caaa"
end if build.with? "maildir"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it is more lines, current style prefers

if build.with? "blah"
  patch do
    url ""
    sha256 ""
  end
end

Trailing conditionals on multi-line statements are easily overlooked.


def install
ENV.j1
system "./configure", "--disable-debug",
Expand Down