Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node@14 14.21.1 #114473

Closed
wants to merge 2 commits into from
Closed

node@14 14.21.1 #114473

wants to merge 2 commits into from

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Nov 1, 2022

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula long build Set a long timeout for formula testing labels Nov 1, 2022
@chenrui333 chenrui333 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Nov 2, 2022
@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 2, 2022
@derrabus
Copy link
Contributor Author

derrabus commented Nov 3, 2022

The error message says:

OpenSearch Dashboards was built with v14.20.0 and does not support the current Node.js version v14.21.0. Please use Node.js v14.20.0 or a higher patch version.

Is there something I can do about that? Or can we ignore that error and bump opensearch-dashboards after this PR has been merged?

@SMillerDev
Copy link
Member

Can you raise this upstream? We can probably ignore it, but it'd be good to check.

@derrabus
Copy link
Contributor Author

derrabus commented Nov 3, 2022

Can you raise this upstream?

I wouldn't know what to ask for, tbh. The issue is that the opensearch-dashboards formula has a build step and during the build the exact node version the build is run with is saved. Since the bottle has been built with an older node@14 binary, we get this error.

Rebuilding the package from source after building node@14 14.21.0 solved the issue locally. I've pushed a revision bump for this package.

Is there a way I can force a rebuild of opensearch-dashboards bottles whenever node@14 is bumped?

@SMillerDev
Copy link
Member

Ah, the situation is different than I expected. Might be good to ask upstream not to pin to a minor version then. Or pin to a minor version in their code, instead of on compiling. Currently it doesn't mean much since a rebuild will change it.

@chenrui333 chenrui333 removed the long build Set a long timeout for formula testing label Nov 4, 2022
@derrabus derrabus changed the title node@14 14.21.0 node@14 14.21.1 Nov 4, 2022
@derrabus
Copy link
Contributor Author

derrabus commented Nov 4, 2022

PR updated for node 14.21.1.

@cho-m
Copy link
Member

cho-m commented Nov 4, 2022 •
edited
Loading

Related: opensearch-project/OpenSearch-Dashboards#2088

Arch Linux currently removes the check: https://github.com/archlinux/svntogit-community/blob/packages/opensearch-dashboards/trunk/PKGBUILD#L55

@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Nov 5, 2022
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Nov 6, 2022
@derrabus
Copy link
Contributor Author

derrabus commented Nov 6, 2022

CI is green. Can we please merge? 🙏🏻

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @SMillerDev @cho-m @BrewTestBot @chenrui333