Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lighthouse 2.3.1 #105810

Closed
wants to merge 1 commit into from
Closed

lighthouse 2.3.1 #105810

wants to merge 1 commit into from

Conversation

PythonCoderAS
Copy link
Contributor

Created with brew bump-formula-pr.

@PythonCoderAS
Copy link
Contributor Author

As per #103752, the PR is being recreated.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` rust Rust use is a significant feature of the PR or issue labels Jul 14, 2022
@chenrui333
Copy link
Member

    make: warning: -jN forced in submake: disabling jobserver mode.
    /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/prost-build-0.10.4/third-party/protobuf/src/google/protobuf/stubs/strutil.cc:1255:19: error: expected unqualified-id
      } else if (std::isnan(value)) {
                      ^
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/math.h:165:5: note: expanded from macro 'isnan'
        ( sizeof(x) == sizeof(float)  ? __inline_isnanf((float)(x))          \
        ^
    /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/prost-build-0.10.4/third-party/protobuf/src/google/protobuf/stubs/strutil.cc:1373:19: error: expected unqualified-id
      } else if (std::isnan(value)) {
                      ^
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/math.h:165:5: note: expanded from macro 'isnan'
        ( sizeof(x) == sizeof(float)  ? __inline_isnanf((float)(x))          \
        ^
    /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/prost-build-0.10.4/third-party/protobuf/src/google/protobuf/stubs/strutil.cc:1255:19: error: expected unqualified-id
      } else if (std::isnan(value)) {
                      ^
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/math.h:165:5: note: expanded from macro 'isnan'
        ( sizeof(x) == sizeof(float)  ? __inline_isnanf((float)(x))          \
        ^
    /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/prost-build-0.10.4/third-party/protobuf/src/google/protobuf/stubs/strutil.cc:1373:19: error: expected unqualified-id
      } else if (std::isnan(value)) {
                      ^
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/math.h:165:5: note: expanded from macro 'isnan'
        ( sizeof(x) == sizeof(float)  ? __inline_isnanf((float)(x))          \
        ^
    2 errors generated.

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 14, 2022
@chenrui333
Copy link
Member

cc @michaelsproul

@cho-m
Copy link
Member

cho-m commented Jul 14, 2022

Looks similar to errors that happen when build scripts don't pick up correct XCode/CLT SDK.

prost-build programmatically calls cmake to build protobuf (v3.14.0), so it may not play well with Homebrew's build environment (e.g. given that it doesn't include all the std_cmake_args).

@PythonCoderAS
Copy link
Contributor Author

There is an entire section on prost_build about protoc: https://docs.rs/prost-build/latest/prost_build/#sourcing-protoc

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 17, 2022
@github-actions github-actions bot closed this Jul 18, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
@chenrui333
Copy link
Member

#106928

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue stale No recent activity superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants