Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename hockeyapp #8706

Merged
merged 2 commits into from
Jan 7, 2015
Merged

rename hockeyapp #8706

merged 2 commits into from
Jan 7, 2015

Conversation

vitorgalvao
Copy link
Member

Closes #7606.

@ndr-qef Feel free to merge if #7606 ended up in agreement.

rolandwalker and others added 2 commits December 5, 2014 14:45
to conform with naming conventions. Add (commented out) `name` stanza.
@tapeinosyne
Copy link
Contributor

Truthfully, I am still rather uneasy about the naming convention as applied here. However, absent a discussion on the topic, this change is consistent and should be merged.

tapeinosyne pushed a commit that referenced this pull request Jan 7, 2015
@tapeinosyne tapeinosyne merged commit 3e15f58 into Homebrew:master Jan 7, 2015
@vitorgalvao vitorgalvao deleted the rolandwalker-rename_hockeyapp branch January 7, 2015 12:16
@vitorgalvao
Copy link
Member Author

For what it's worth, I do agree with the change. Although I certainly follow your logic and do find it makes sense, naming (tokening) is so complex and there are so many possibilities, I believe a strict rule that can be applied uniformly and miss a few marks (mitigated by name) is better than relaxing the rule one too many times and end up with duplicates or confusion for users submitting (since the implementation of the rules, I have seen way less submissions requiring correction in that area).

@tapeinosyne
Copy link
Contributor

I feel that this particular convention is counterproductive, and should either be amended or relaxed. It leads to duplicate submissions (at least three or four duplicates for CloudApp, between GitHub and IRC) and confusion for end users.

@vitorgalvao
Copy link
Member Author

should either be amended or relaxed.

I take no issue with amending it. Relaxing it would lead to some inconsistencies, I feel. ack "app .*App.app", in an attempt to reveal how many apps use the “app” suffix, reveals way less than what I expected (likely I’m not considering something in that command).

CloudApp is probably the one that suffers the most from this rule, but in a way that’s a bigger fault of its name than of the rule itself. Naming it simply “cloud” does feel wrong and incomplete, but that’s greatly in part on it’s name consisting of two extremely generic terms pushed together (which likely makes for great marketing and makes it higher in search results). I’m not at all saying we shouldn’t accommodate the rule according to the casks we have, as we definitely should, but I do think either allowing or refusing all “app” sufixes is a rule that needs to be in place. Whichever it is, I don’t really care that much: the more we shift the focus to name and away from the token (which as stated, we ask too much of), the better.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants