Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Rip Actions for Automator #8178

Closed
wants to merge 3 commits into from
Closed

Batch Rip Actions for Automator #8178

wants to merge 3 commits into from

Conversation

plessbd
Copy link
Contributor

@plessbd plessbd commented Dec 17, 2014

used for ripping and encoding your physical media

used for ripping and encoding your physical media
@jawshooah
Copy link
Contributor

Are cask dependencies a thing? Seems like this requires a few external applications/libraries, and while it provides download links in the menu bar, I'm sure most people (myself included) would prefer to install any dependencies via brew/cask.

@jawshooah
Copy link
Contributor

This could also do with a zap stanza, what with everything it dumps into ~/Library/Services.

add zap stanza to remove services.
Directories possibly created under ~/Movies are not deleted as they may contain data.
@plessbd
Copy link
Contributor Author

plessbd commented Dec 17, 2014

I added a zap stanza. I could not determine how to do a depends_on other casks though.

@vitorgalvao
Copy link
Contributor

It’s not yet possible to depends_on other casks, but it is planned. I agree with @jawshooah: if other apps are needed, we should hold merging this a bit.

Add caveats until depends_on can support other casks.
@plessbd
Copy link
Contributor Author

plessbd commented Dec 17, 2014

how about a caveat that tells you what you need to do until depends_on is supported. Seems like a good compromise, especially since there are "options" depending on what you actually need / want to do with these actions.

@vitorgalvao
Copy link
Contributor

We can start building it like if depends_on :cask were already available, because it will be, soon.

@plessbd
Copy link
Contributor Author

plessbd commented Dec 17, 2014

I know with homebrew you can pass options, is there a way to do this with cask?

Specifically, I do not have a Blu-Ray player and I have already ripped the DVD to the vob files, all I need is encode capabilities.

So I would prefer to not install the bluray or libdvdcss packages.

If I just missed something in docs please let me know.

@vitorgalvao
Copy link
Contributor

I know with homebrew you can pass options, is there a way to do this with cask?

Not yet. We could err on the side of caution and simply require them all. However, your caveat is explicit, and could also work fine (I definitely see your point to not install the extra cruft). I don’t have a strong opinion on this one, so I’ll ping @rolandwalker @ndr-qef and @claui, and defer the decision.

@rolandwalker
Copy link
Contributor

Hi @plessbd !

Homebrew has a way to define soft (recommended) dependencies as well as hard (required) ones. We are just in the process of implementing hard dependencies, but I'm sure we can get to soft dependencies in time.

Meanwhile, the caveats seem good to me. The software works without those items, and you have gone the extra mile to show users how to get more functionality.

However – since #6570 we have started being more careful about what we include here. Our standards are fairly simple in that we want software with a clearly identifiable vendor who stands behind their work. Dropbox URLs are undesirable, but workable when they cannot be avoided. But a forum posting is just not enough for a homepage.

This stuff is not fully documented as we are still hashing out the boundaries, and the main repo is not even fully compliant with the parts we have decided.

Could we find an identifiable vendor for this cool Cask? Or send it to homebrew-unofficial ?

@vitorgalvao
Copy link
Contributor

@rolandwalker I see skii as a different matter — it once had a vendor and now it does not, raising suspicion on the new domain owners, who seem to be squatters. Going back to the argument of “we’re not a discoverability service, so you actually need to know what you’re getting into”, skii might be dangerous now because people who knew about it before may try to get it now, and we have no idea if who’s serving it is trustworthy, but it is not who users expect to be.

This, however, along with kext-wizard and ninjablocks1 always had a forum post as its home, so if a user knows about it, they should be familiar with where it came from.


1 Actually that one may need a revision, as that might be an unofficial build.

@rolandwalker
Copy link
Contributor

I, personally, follow your logic perfectly, but it's too much context for a simple rule that everyone can use.

Similar to your point about clarifying licensing by narrowing our view to the binary itself, knowing where a Cask goes shouldn't require knowledge of history. We should be able to look at the Cask and say: "Forum posting. This critter is vendorless. Unofficial."

Otherwise we have a situation where a forum posting goes in the main repo if it has never had a vendor, but into unofficial if it had a vendor once upon a time. Not only hard to remember, but arguably backwards in terms of degree-of-trustworthiness.

kext-wizard and anything without a vendor should migrate to unofficial. And it is relevant to skii, inasmuch as forum postings are a common distribution mechanism for malware. (Nothing against kext-wizard; I use it myself.)

@vitorgalvao
Copy link
Contributor

Agreed. @plessbd Could you please submit this to caskroom/unofficial instead?

@plessbd
Copy link
Contributor Author

plessbd commented Dec 30, 2014

@plessbd plessbd closed this Dec 30, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants