Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates eid-mw to v4.0.7 #8026

Merged
merged 1 commit into from
Dec 23, 2014
Merged

Conversation

jeroenj
Copy link
Contributor

@jeroenj jeroenj commented Dec 11, 2014

Also updates the homepage to point to the official website. The dmg
package will be downloaded from there too.

homepage 'https://code.google.com/p/eid-mw/'
version '4.0.7'
sha256 '12ef509d3e535714e7c81353979d7637da594293be81411adfc6f6ea4511374b'
url "http://eid.belgium.be/nl/binaries/beid-#{version}-7780-signed_tcm227-259517.dmg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please readd the blank line before url.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I must have accidentally removed it. Fixed now. :)

@vitorgalvao vitorgalvao self-assigned this Dec 11, 2014
@vitorgalvao
Copy link
Member

I’ve edited the comment out so we don’t delay the merging of the update more than necessary. The question also should be on an issue of its own, so the discussion should continue at #8033.

Still pinging @radeksimko specifically, pertaining java, since it concerns the cask’s update. We get the following warning when trying to open the app

I found a few different java caveat messages in a few different casks. Which would be the appropriate one here?

@jeroenj
Copy link
Contributor Author

jeroenj commented Dec 11, 2014

Installing the java cask will solve the issue you describe with java. Should I add it to caveat messages or something like that? I'd be happy to fix it. :)

@vitorgalvao
Copy link
Member

Yes, the caveat should be added, I’m just not sure which one. @radeksimko is very active on these java issues and I’m not entirely up-to-date on which the latest agreements are with them, so I defer to him in these cases.

@jeroenj
Copy link
Contributor Author

jeroenj commented Dec 11, 2014

Great. I'll fix it as soon as I know what's recommended. :)

@radeksimko
Copy link
Contributor

There's no consistent solution for this yet. We're currently in kind of a middle stage of creating a proper java dependency stanza, so until we implement it, I'd go for the caveat at the moment.

Have a look at some good examples:
https://github.com/caskroom/homebrew-cask/blob/master/Casks/intellij-idea.rb#L20-29
https://github.com/caskroom/homebrew-cask/blob/master/Casks/filebot.rb#L11 - more brief

Rather than having a caveat "Java required", it is actually much more important to find out which Java versions are actually supported and inform the user about these.

More over there's a common issue with all IntelliJ-based IDEs which causes all these editors to not work out of the box with Java 7+ although when you do a tiny modification in Info.plist, it actually works.

@jeroenj The recommended solution here is therefore testing it with particular versions of Java (6, 7, 8) and also no Java and then come up with a precise caveat. Will you be able to do it? ;)

@jeroenj
Copy link
Contributor Author

jeroenj commented Dec 21, 2014

It took me a while but I can confirm that it works with Java 6, 7 and 8 (latest available versions). I've added a caveat explaing that java is required.

Since the discussion about renaming this cask has been moved to #8033 I guess this can be merged if the caveat is okay?

@vitorgalvao
Copy link
Member

@jeroenj We can worry about renaming later, yes. I’d change the caveat a bit, though, something like

caveats  <<-EOS.undent
  #{token} requires Java. You can install the latest version with
    brew cask install java
EOS
end

In addition, could you please squash your commits?

@jeroenj jeroenj force-pushed the eid-mw-update branch 2 times, most recently from bbfcab0 to 7a57d06 Compare December 23, 2014 10:00
Also updates the homepage to point to the official website. The dmg
package will be downloaded from there too.
And also mentions that java is required. It has been tested with java 6,
7 and 8.
@jeroenj
Copy link
Contributor Author

jeroenj commented Dec 23, 2014

Done. :)

@vitorgalvao
Copy link
Member

Thank you.

vitorgalvao added a commit that referenced this pull request Dec 23, 2014
@vitorgalvao vitorgalvao merged commit 7d9ab47 into Homebrew:master Dec 23, 2014
@jeroenj jeroenj deleted the eid-mw-update branch June 4, 2015 15:14
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants