-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates eid-mw to v4.0.7 #8026
Updates eid-mw to v4.0.7 #8026
Conversation
homepage 'https://code.google.com/p/eid-mw/' | ||
version '4.0.7' | ||
sha256 '12ef509d3e535714e7c81353979d7637da594293be81411adfc6f6ea4511374b' | ||
url "http://eid.belgium.be/nl/binaries/beid-#{version}-7780-signed_tcm227-259517.dmg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please readd the blank line before url
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I must have accidentally removed it. Fixed now. :)
I’ve edited the comment out so we don’t delay the merging of the update more than necessary. The question also should be on an issue of its own, so the discussion should continue at #8033. Still pinging @radeksimko specifically, pertaining java, since it concerns the cask’s update. We get the following warning when trying to open the app I found a few different java caveat messages in a few different casks. Which would be the appropriate one here? |
a967944
to
5b7e22c
Compare
Installing the java cask will solve the issue you describe with java. Should I add it to caveat messages or something like that? I'd be happy to fix it. :) |
Yes, the caveat should be added, I’m just not sure which one. @radeksimko is very active on these java issues and I’m not entirely up-to-date on which the latest agreements are with them, so I defer to him in these cases. |
Great. I'll fix it as soon as I know what's recommended. :) |
There's no consistent solution for this yet. We're currently in kind of a middle stage of creating a proper java dependency stanza, so until we implement it, I'd go for the caveat at the moment. Have a look at some good examples: Rather than having a caveat "Java required", it is actually much more important to find out which Java versions are actually supported and inform the user about these. More over there's a common issue with all IntelliJ-based IDEs which causes all these editors to not work out of the box with Java 7+ although when you do a tiny modification in @jeroenj The recommended solution here is therefore testing it with particular versions of Java (6, 7, 8) and also no Java and then come up with a precise caveat. Will you be able to do it? ;) |
It took me a while but I can confirm that it works with Java 6, 7 and 8 (latest available versions). I've added a caveat explaing that java is required. Since the discussion about renaming this cask has been moved to #8033 I guess this can be merged if the caveat is okay? |
@jeroenj We can worry about renaming later, yes. I’d change the caveat a bit, though, something like caveats <<-EOS.undent
#{token} requires Java. You can install the latest version with
brew cask install java
EOS
end In addition, could you please squash your commits? |
bbfcab0
to
7a57d06
Compare
Also updates the homepage to point to the official website. The dmg package will be downloaded from there too. And also mentions that java is required. It has been tested with java 6, 7 and 8.
7a57d06
to
3169194
Compare
Done. :) |
Thank you. |
Also updates the homepage to point to the official website. The dmg
package will be downloaded from there too.