-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use installer :manual
in 21 Casks
#6873
Merged
tapeinosyne
merged 22 commits into
Homebrew:master
from
rolandwalker:installer_manual_casks
Oct 22, 2014
Merged
use installer :manual
in 21 Casks
#6873
tapeinosyne
merged 22 commits into
Homebrew:master
from
rolandwalker:installer_manual_casks
Oct 22, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloaded and checked to clear the ambiguity.
use installer :manual in omnifocus-clip-o-tron.rb
rolandwalker
changed the title
use
use Oct 21, 2014
installer :manual
in 20 Casksinstaller :manual
in 21 Casks
tapeinosyne
pushed a commit
that referenced
this pull request
Oct 22, 2014
use `installer :manual` in 21 Casks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned elsewhere,
installer
is a very late addition to the DSL (#6660, only available in the latest release 0.45.0).This PR is the most-disruptive change put forward so far during the DSL transition, as >20 Casks are touched, and the relevant backend support is recent. However, 20 Casks seems reasonably small, and the
method_missing
warning will guide users to upgrade.