Acceptable cases for :target

[vitorgalvao]

@caskroom/maintainers Stemming from the conversation in #6375, this is the proposal (with appropriate changes) for the rules pertaining to the use of :target. Its use with app has been tightened, while its use with binary has remained liberal in comparison (if it should remain so is also something that should be agreed upon).

Regarding apps, I’ve tried to keep the message consistent between them, and found three main reasons for renaming with :target:

• For clarity: app name is inconsistent with its branding.
• For consistency: app name is different in the Finder and in a shell.
• To avoid conflict.

[rolandwalker]

+1. Thanks for drilling into this. I reviewed and checked for a few cases which are known to me such as LogMeIn.

The imagemin.rb quoting issue is my fault from one of the recent mass updates.

BTW some of the Chinese-language apps also have an inconsistency between app bundle name as visible in Finder, and app name as visible in the menu.

[vitorgalvao]

Do you know which ones? The ones I’ve checked seemed fine.

baiducloud
baiduinput
baidumusic
powerword
qiyimedia
sogouinput
thunder
youdao

[alebcay]

I would check thunder.

[vitorgalvao]

Also clean. Adding it to the previous list, so we can keep track.

[rolandwalker]

Sorry, I can't remember. It might have been fixed upstream.

[rolandwalker]

Repaired the conflicts and merged manually. Sorry if you weren't ready; I wanted to get the imagemin fix in.

[vitorgalvao]

It’s fine, it was ready; was just waiting to see if there were any objections. Thank you for taking care of the conflicts.