remove deletions of Apple-identified files

[rolandwalker]

Fixes #4409. These globs were in single-quotes, so they were not
currently being expanded, and therefore were having no effect anyway.
We also have an (undocumented) policy against manipulating files
identified to Apple.

[rolandwalker]

@vitorgalvao , would documenting that fit in with the other docs you are working on, or should I do that separately?

@sigito, GitHub seems to have lost your history on this file (which is weird!), but I think you were the original author. Maybe we don't have to religiously stick to our rule against deleting com.apple files, since it is only caches here — if you would be so kind as to explain the rationale?

If we did keep these, we would have to enclose the strings containing * with Dir.glob so that they would get expanded, eg

  system 'rm', '-f', '--', Dir.glob('/System/Library/Caches/com.apple.IntlDataCache.le*')

[sigito]

@rolandwalker this deletion of cache files was added according to uninstall section of package documentation. Unfortunately, I am not an author of the software, so cannot say whether we can skip this step.

[rolandwalker]

The link is very helpful info, thanks @sigito !

[vitorgalvao]

@rolandwalker Haven’t yet decided the best place to put the information, although if you think a document with “things to pay attention to” would be warranted, they could certainly fit together.

So far, I’m thinking about including the information about MAS-only apps in “Finding A Home For Your Cask”. It seems like the most natural place to inform users of casks that should not be submitted. That way we’re also covered if someone decides to create a trials tap — we’d just need a small documentation update.

[adidalal]

Closing as this PR is outdated.

Not removing Apple-identified files should be added to the zap documentation, and glob expansion has yet to be implemented, anyways.