Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Firefox-DE (Latest) #3506

Closed
wants to merge 1 commit into from
Closed

Conversation

fharbe
Copy link
Contributor

@fharbe fharbe commented Mar 11, 2014

Added German Firefox for OSX.

@alebcay
Copy link
Member

alebcay commented Mar 11, 2014

I'm not sure on the policy for non-English casks is when an English version exists. By this logic, should we perhaps also have Casks for the Chinese Firefox? Japanese? French? etc.

The Caskroom would quickly get saturated by non-English casks for big multilingual apps (e.g. Firefox, Thunderbird, and those OpenOffice language packs). Perhaps another place like Caskroom/homebrew-versions would be a better (but not ideal) place, although I personally would advocate for another repo 'Caskroom/homebrew-languages' or something of that sort.


Or we could just add this, which is fine too. Pinging @rolandwalker and @vitorgalvao for their opinions.

@rolandwalker
Copy link
Contributor

Grüß Gott @fharbe! Thanks for the submission.

@alebcay, it would be great for the DSL to support a syntax like localization do ... end so that localizations could all be kept in one Cask. However, for that to work correctly we would need a way for the user to specify their choice at the CLI, and proper management for multiple versions (being worked on).

In the meantime my vote would be to put this in homebrew-versions. A separate homebrew-languages makes sense from an organizational point-of-view, but we don't know yet if there will be enough localized Casks to justify a separate Tap.

@vitorgalvao
Copy link
Member

The point on different languages has been briefly touched on in #142 (long-standing issue). I also say this should go into caskroom versions. Could you please submit it there, @fharbe?

@fharbe
Copy link
Contributor Author

fharbe commented Mar 12, 2014

Grüß Gott – hey there!

Thank you for your vote – I will add a new Pull Request for this to be
pulled into homebrew-versions.

I also think there should be a way to define the user's "localization"
preferences. Maybe there will be a way in the future to set this via the
CLI.

@alebcay alebcay mentioned this pull request Apr 6, 2014
@fharbe fharbe deleted the firefox-de branch November 19, 2014 16:56
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants