Presstube screensavers

[jedahan]

The presstube screensavers have some dependencies, we just have to figure out what they are. Problem described in #2647 (comment)

[rolandwalker]

Hi again! Your commit ca61dfd got caught in this branch, but I already merged that code.

There's no rush to figure out the screensaver Casks anyway, as they won't function for anyone before the next code release (the Cask definitions update directly from HEAD, the code updates only on a release, so we have to hold back Casks that are not supported by the released code).

I've tried installing Flash for these, which was insufficient, would be nice to get some other testers on this PR.

[rolandwalker]

The dependency seems to be Adobe Air. There's a Cask for that, so you can just add caveats to these Casks like so:

caveats do
  <<-EOS.undent
  Cask #{@cask} requires the Adobe Air runtime.  If you have not installed
  Adobe Air, you may do so via

    brew cask install adobe-air

  EOS
end

We only just added the ability to specify dependencies against Homebrew Formulae in #2305. Unfortunately, automatic dependencies against other Casks is not here yet, but that feature is definitely on my todo list.

Cheers!

PS You don't need self on self.destination_path.

[jedahan]

Weird as I do not have adobe air installed...

[rolandwalker]

Also weird as they kept on working for me after uninstalling Adobe Air. How about just softening the caveats language to say something like "if you have problems, try installing Adobe Air".

Later, if we get bug reports, we will deal with them.

[rolandwalker]

Thanks! This can be merged now as v0.28.0 was released.

Your new artifact type will be supported after doing brew update && brew upgrade brew-cask.