BUGFIX: readlink requires chdir for relative links #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Homebrew#2650 (although there is more work to be done). The issue is that path.readlink.exist? returned false for all relative links, because readlink reads relative to the current working directory. This caused relative symlinks such as /usr/bin/tar to be deleted, because package mosh identified /usr/bin as one of its container directories. The simplest fix is not to use readlink at all, because path.exist? will tell us what we want to know, independent of current dir.
rolandwalker
added a commit
that referenced
this pull request
Jan 29, 2014
BUGFIX: readlink requires chdir for relative links
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2650 (although there is more work to be done). The issue is that
path.readlink.exist?returned false for all relative links, becausereadlinkreads relative to the current working directory. This caused relative
symlinks such as
/usr/bin/tarto be deleted, because packagemoshidentified/usr/binas one of its container directories.