always submit external commands in list form #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For safety. - This is a step toward reworking system_command.rb so that invocations are done in list form on the back end, avoiding surprises from quoting and shell metacharacters. - There is one transitional hack here: the _quote method in Cask::SystemCommand is modified to avoid double-quoting. The _quote method itself will go away in a future revision when only list-forms are used. - Casks using system are not touched. It seems natural to address that when creating the DSL for after_install/before_install.
rolandwalker
added a commit
that referenced
this pull request
Jan 25, 2014
always submit external commands in list form
|
Ah yes I've been moving in this direction with code I've touched too. Glad to see you agree, and good catches on the ones you changed. 🍞 |
|
good, I have a series of 3 or 4 more PRs that will make us very robust on external commands. looks like @vmrob is also working on some of the same lines. |
This was referenced Jan 25, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For safety.
invocations are done in list form on the back end, avoiding
surprises from quoting and shell metacharacters.
Cask::SystemCommand is modified to avoid double-quoting. The
_quote method itself will go away in a future revision when
only list-forms are used.
address that when creating the DSL for after_install/before_install.