Refactoring. #23821
Merged
Refactoring. #23821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,15 +3,14 @@ | |||
| class Hbc::Source::UntappedQualified < Hbc::Source::TappedQualified | |||
| def self.path_for_query(query) | |||
| user, repo, token = Hbc::QualifiedToken.parse(query) | |||
| token.sub!(%r{\.rb$}i, "") | |||
| tap = "#{user}/homebrew-#{repo}" | |||
| tap = "#{user}/#{Hbc::QualifiedToken::REPO_PREFIX}#{repo}" | |||
There was a problem hiding this comment.
Since this is repeated in several places, it's probably worthwhile to extract it into a method (assuming Homebrew doesn't already have an equivalent one)
There was a problem hiding this comment.
Nice, Homebrew's Tap class already has a cask_dir method. 👍
| # Override Tap::TAP_DIRECTORY to use our test Tap directory. | ||
| class Tap | ||
| send(:remove_const, :TAP_DIRECTORY) | ||
| TAP_DIRECTORY = Hbc.homebrew_prefix.join("Library", "Taps") |
There was a problem hiding this comment.
@jawshooah, do you know a more elegant way to redefine constants, or an alternative approach?
reitermarkus
added
enhancement
core
4 tasks
jedahan
pushed a commit
to jedahan/homebrew-cask
that referenced
this pull request
Sep 24, 2016
* Refactoring. * Refactor pre-/postflight block artifacts. * Use Homebrew’s `Tap` class. * Overwrite TAP_DIRECTORY constant.
miccal
removed
the
awaiting maintainer feedback
miccal
removed
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the core