Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zight 8.4.0.2954 #197537

Merged
merged 1 commit into from
Jan 8, 2025
Merged

zight 8.4.0.2954 #197537

merged 1 commit into from
Jan 8, 2025

Conversation

samford
Copy link
Member

@samford samford commented Jan 8, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@samford
Copy link
Member Author

samford commented Jan 8, 2025

Hm, livecheck is still returning 8.4.0,2954 for me locally and that's the version I see in the Sparkle feed when fetching it manually.

$ curl https://share.zight.com/api/v4/clients/mac/current-version
<rss version="2.0" xmlns:sparkle="http://www.andymatuschak.org/xml-namespaces/sparkle" xmlns:dc="http://purl.org/dc/elements/1.1/">
  <channel>
    <title>CloudApp Appcast</title>
    <description>Most recent changes with links to updates.</description>
    <link>http://downloads.zight.com/mac</link>
    <language>en</language>
    <item>
      <title>Zight 8.4.0 (2954)</title>
      <pubDate>Tue, 17 Dec 2024 00:00:00 +0000</pubDate>
      <enclosure url="https://downloads.zight.com/mac/Zight-8.4.0.2954.zip" sparkle:version="2954" sparkle:shortVersionString="8.4.0" type="application/octet-stream" length="97295510"/>
    </item>
  </channel>
</rss>

@krehel
Copy link
Member

krehel commented Jan 8, 2025

I'm still getting 8.3.0,2897 both from livecheck and the Sparkle feed 😅

@samford
Copy link
Member Author

samford commented Jan 8, 2025

I tested this again and it switches back and forth between either version (whether using brew livecheck or curl), so they must be doing some sort of A/B testing or gradual version rollout. I guess it's too much to ask that an API endpoint named current-version simply does what the name suggests 😆

@khipp khipp merged commit c3f073f into master Jan 8, 2025
11 checks passed
@khipp khipp deleted the zight-8.4.0.2954 branch January 8, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants