Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyCharm: Add Command Line Tool #15876

Closed
wants to merge 1 commit into from
Closed

PyCharm: Add Command Line Tool #15876

wants to merge 1 commit into from

Conversation

reitermarkus
Copy link
Member

No description provided.

@vitorgalvao
Copy link
Member

This is smart. And it definitely treads shim script territory.

It’s my understanding these tools will actually guide you through the process of making such CLI executable on first run, isn’t that so? In that case, I see this as a potential source for conflict (we should assume that if the tool is asking it, the user will assume we didn’t make such executable).

@vitorgalvao vitorgalvao added enhancement cask awaiting maintainer feedback Issue needs response from a maintainer. awaiting user reply Issue needs response from a user. discussion and removed awaiting maintainer feedback Issue needs response from a maintainer. awaiting user reply Issue needs response from a user. labels Dec 16, 2015
@adidalal
Copy link
Contributor

See also #12028 for previous discussion.

@vitorgalvao
Copy link
Member

Thank you for that link, @adityadalal924. Had forgotten about that discussion.

I’m more inclined to follow this comment and close this issue and that one.

@reitermarkus
Copy link
Member Author

The main issue here is of course that you would have to update it manually every time you update the application because the cask directory gets a new version number. Anyway, I don't think this will be an issue once the new installation behaviour is implemented as the path will stay the same.

@adidalal
Copy link
Contributor

@reitermarkus You're correct on both.

In that case, both this PR and the older issue should be closed, as we'll try to keep working towards the best long-term solution rather than adding in short-term fixes that end up making things difficult in the long run.

@adidalal adidalal closed this Dec 16, 2015
@reitermarkus reitermarkus deleted the pycharm-clt branch December 16, 2015 21:59
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants