Update ngrok zap #13083
Update ngrok zap #13083
Conversation
Adds zap config for ngrok
| @@ -9,6 +9,6 @@ | |||
|
|
|||
| binary 'ngrok' | |||
|
|
|||
| # todo verify that this does not contain user-created content | |||
| # zap :delete => '~/.ngrok' | |||
| zap :delete => '~/.ngrok2/ngrok.yml', | |||
There was a problem hiding this comment.
Why not leave it as in the comment?
There was a problem hiding this comment.
ngrok was updated to version 2, and with that, the config structure changed
"ngrok's configuration file format has been redesigned to be simpler and expose more options. The configuration file for 2.0 is a simple YAML file read by default from $HOME/.ngrok2/ngrok.yml"
There was a problem hiding this comment.
To clarify, what I meant is, why not leave simply as zap :delete => '~/.ngrok2? Why remove the file and then the directory only if it’s empty?
There was a problem hiding this comment.
The user can have multiple configurations stored there, but needs to manually create any besides ngrok.yml, so I thought that would fall under "user-generated content"
There was a problem hiding this comment.
Ah, no, we discussed that and came to the conclusion zap should remove everything.
There was a problem hiding this comment.
Okay, then just the delete should be fine to merge in
|
Thank you for the contribution. It needed some fixes, so they were made in 6295e11. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes. |
Adds zap config for ngrok
Progress on #8202