Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minecraft-server from 1.16.5,1b557e7b033b583cd9f66746b7a9ab1ec1673ced to 1.17,0a269b5f2c5b93b1712d0f5dc43b6182b9ab254e #107143

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 11, 2021

Created with brew bump-cask-pr.

…1673ced to 1.17,0a269b5f2c5b93b1712d0f5dc43b6182b9ab254e
@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Jun 11, 2021
@miccal
Copy link
Contributor

miccal commented Jun 11, 2021

@cho-m
Copy link
Member Author

cho-m commented Jun 11, 2021

Looks like they compiled on JDK 16 (class version 60.0):

Error: LinkageError occurred while loading main class net.minecraft.server.Main
	java.lang.UnsupportedClassVersionError: net/minecraft/server/Main has been compiled by a more recent version of the Java Runtime (class file version 60.0), this version of the Java Runtime only recognizes class file versions up to 58.0

The CI JRE seems to be only able to run up to JDK 14 (class version 58.0).

Not sure if this was intentional, but looks like we may need JRE 16 to test.

@cho-m
Copy link
Member Author

cho-m commented Jun 12, 2021

https://minecraft.fandom.com/wiki/Tutorials/Update_Java

Since Java Edition 1.17(21w19a), Minecraft requires Java 16 or newer.

https://www.minecraft.net/en-us/article/minecraft-snapshot-21w19a

If you are using a custom Java setup or a third-party launcher, you will need to ensure that your Java installation is version 16 or above.

I'll update caveat, but I am not sure if CI handles this correctly (or if we need #16383)

@cho-m
Copy link
Member Author

cho-m commented Jun 13, 2021

Based on https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md, I see that the current failure is probably due to max Java 14 in default environment:

Version Vendor Environment Variable
8.0.292+10 (default) Adopt OpenJDK JAVA_HOME_8_X64
11.0.11+9 Adopt OpenJDK JAVA_HOME_11_X64
12.0.2+10.3 Adopt OpenJDK JAVA_HOME_12_X64
13.0.2+8.1 Adopt OpenJDK JAVA_HOME_13_X64
14.0.2+12 Adopt OpenJDK JAVA_HOME_14_X64

To get past CI failure, may need to add another GitHub Action step that installs Java 16 (maybe dependent on caveat value).

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Jun 15, 2021
@cho-m cho-m added in progress and removed stale Issue which has not received any feedback for some time. labels Jun 15, 2021
@cho-m cho-m added the ci-skip-install Skip installation on CI. Use only when no fix can be found. label Jun 25, 2021
@cho-m
Copy link
Member Author

cho-m commented Jun 25, 2021

For now, just skipping install as this requires CI changes to support testing on JDK 16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` ci-skip-install Skip installation on CI. Use only when no fix can be found. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants