Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew cask list is TOO SLOW #911

Closed
phinze opened this issue Aug 12, 2013 · 2 comments
Closed

brew cask list is TOO SLOW #911

phinze opened this issue Aug 12, 2013 · 2 comments

Comments

@phinze
Copy link
Contributor

phinze commented Aug 12, 2013 

> time brew cask list > /dev/null
brew cask list > /dev/null  0.30s user 0.05s system 20% cpu 1.730 total

ONE POINT SEVEN SECONDS? 🕐 💣 🔥 😠

Comparatively listing all available casks:

> time brew cask search > /dev/null
brew cask search > /dev/null  0.07s user 0.03s system 97% cpu 0.102 total

100ms I can live with.

Should look into why list is so annoyingly slow.
@passcod
Copy link
Contributor

passcod commented Aug 13, 2013

Easy: list loads every cask and filters them by installation status, while search only accesses the filesystem and greps through (see scopes.rb).

The solution to this is to use the Caskroom as an indicator of whether apps are installed or not... and it ties it in nicely with #316. Boom.

@phinze phinze mentioned this issue Oct 2, 2013
Closed
phinze added a commit that referenced this issue Oct 2, 2013
@phinze
change opera-next to specific release
6205346 
removes inline web request for every class-load

refs #1111 and #911
@hanxue hanxue mentioned this issue Oct 31, 2013
Closed
@hanxue
Copy link
Contributor

hanxue commented Oct 31, 2013

I have created #1416 to address this. Can someone please take a look at the commit comments please?

hanxue added a commit to hanxue/caskroom that referenced this issue Nov 18, 2013
@hanxue
Changing listing of installed Cask for improved performance. Fix for H…
e716cd5 
…omebrew#911
@hanxue hanxue mentioned this issue Nov 18, 2013
Closed
kevinSuttle pushed a commit to kevinSuttle/homebrew-cask that referenced this issue Dec 8, 2013
@phinze
change opera-next to specific release
d118195 
removes inline web request for every class-load

refs Homebrew#1111 and Homebrew#911
@miccal miccal removed the bug Issue describing a reproducible bug. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@phinze @passcod @rolandwalker @hanxue @miccal