Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Provide vagrant 2.2.15 #11125

Closed
wants to merge 1 commit into from
Closed

Conversation

timvisher
Copy link

This is provided because 2.2.16 has a bug where it cannot be used with
RSA SHA1 ssh keys which makes it impossible to use with vagrant-aws as
well as any other platform that only supports RSA SHA1 keys. There's
been no activity from the vagrant maintainers to fix this so until
something's done about it it should be easy to install 2.2.15. I believe
this qualifies as a 'clear demonstrable need'.

hashicorp/vagrant#12344

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.

  • [-] Checked the cask was not already refused.

    I see some issues regarding older Vagrant versions being refused. At the
    same time I think this submission should at least be considered based on
    the 'clear demonstrable need' of anyone needing to use varant to
    interact with computer providers that require the use of SHA1 RSA keys.

  • Checked the cask is submitted to the correct repo.

  • brew audit --new-cask <cask> worked successfully.

  • brew install --cask <cask> worked successfully.

  • brew uninstall --cask <cask> worked successfully.

This is provided because 2.2.16 has a bug where it cannot be used with
RSA SHA1 ssh keys which makes it impossible to use with vagrant-aws as
well as any other platform that only supports RSA SHA1 keys. There's
been no activity from the vagrant maintainers to fix this so until
something's done about it it should be easy to install 2.2.15. I believe
this qualifies as a 'clear demonstrable need'.

hashicorp/vagrant#12344
# something's done about it it should be easy to install 2.2.15.
#
# https://github.com/hashicorp/vagrant/issues/12344
cask "vagrant2-2-15" do
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular tokenization is required by brew audit but it seems quite awkward. Is there any way to show it as 2.2.15?

@timvisher
Copy link
Author

There's been a response from the maintainers on the upstream issue so this may not be necessary.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jun 27, 2021
@timvisher
Copy link
Author

While it's looking increasingly unlikely for this to actually be necessary I'm still curious about the name tokenization, etc. Any thoughts on that?

@github-actions github-actions bot removed the stale label Jun 29, 2021
@bevanjkay
Copy link
Member

@timvisher This situation has generally not been a usecase for homebrew-cask-versions. Legacy versions are utilised when an application receives a major upgrade with breaking changes / different minimum software or hardware requirements. In this instance it would be recommended that you install this particular version of Vagrant manually, as this is a once off situation and the cask would not be likely to receive further updates.

@timvisher
Copy link
Author

@bevanjkay Got it. Thanks for the explanation. :)

@timvisher timvisher closed this Jun 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants