Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Rename font-dejavusansmono-nerd-font→font-dejavu-sans-mono-nerd-font #2188

Merged

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Jul 11, 2020

This makes the filename more readable, and is consistent with font-dejavu-sans-mono-for-powerline.

Note that the other nerd-fonts fonts don't use a consistent nomenclature either: there are hyphen-separated cask names like font-fira-code-nerd-font, but also joined ones like font-robotomono-nerd-font. I'd be happy to add hyphens to the remaining ones as well, if that's acceptable.


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask audit --new-cask {{cask_file}} worked successfully.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.

This makes the filename more readable, and is consistent with `font-dejavu-sans-mono-for-powerline`.
@vitorgalvao
Copy link
Member

I'd be happy to add hyphens to the remaining ones as well, if that's acceptable.

It is. Thank you.

@vitorgalvao vitorgalvao merged commit 908c240 into Homebrew:master Jul 13, 2020
@waldyrious waldyrious deleted the rename-dejavu-sans-mono-nerd branch July 13, 2020 14:12
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants