Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-bot: Install dependencies for Cask container tests. #747

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Aug 18, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

In preparation of #725,

  • adobe-air
  • cabextract
  • unar and
  • xz

have to be installed before running brew cask-tests, otherwise some of the container tests will be skipped.

@MikeMcQuaid
Copy link
Member

have to be installed before running brew cask-tests, otherwise some of the container tests will be skipped.

Longer-term we need to figure out a way of testing these things that doesn't require additional dependencies being installed on our bots (like brew tests does). Eventually we'll want to merge brew tests and brew cask-tests too.

Unfortunately the brew install does an implicit tap of homebrew/core which will be relatively slow. Where are the casks stored in this case? It's not testing a /usr/local Homebrew install.

@reitermarkus reitermarkus force-pushed the test-bot-cask-container-dependencies branch 2 times, most recently from 8bd555c to ba8d79f Compare August 19, 2016 15:34
@reitermarkus
Copy link
Member Author

Longer-term we need to figure out a way of testing these things that doesn't require additional dependencies

I completely agree, however, I don't see a way to test the correct detection and extraction of containers without having the tools to extract them installed. I think we can neglect at least cabextract and xz for now, as there aren't any Casks using them. Also only one using unar will be left after Homebrew/homebrew-cask#23918 is merge.

@MikeMcQuaid
Copy link
Member

I completely agree, however, I don't see a way to test the correct detection and extraction of containers without having the tools to extract them installed. I think we can neglect at least cabextract and xz for now, as there aren't any Casks using them.

Sounds like a good argument to 💀 that code 😉.

test "brew", "cask", "install", "https://raw.githubusercontent.com/caskroom/homebrew-cask/master/Casks/adobe-air.rb"
test "brew", "install", "https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/cabextract.rb"
test "brew", "install", "https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/unar.rb"
test "brew", "install", "https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/xz.rb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be enough to have these installed systemwide on the build machines? This means they would likely not be kept particularly up-to-date but might be nicer than sticking them here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's possible, yes, as long as they can extract the containers I don't care if they are up-to-date.

@reitermarkus reitermarkus force-pushed the test-bot-cask-container-dependencies branch from ba8d79f to 2506c22 Compare August 19, 2016 15:57
@reitermarkus reitermarkus force-pushed the test-bot-cask-container-dependencies branch from 2506c22 to 39d07a2 Compare August 19, 2016 23:24
@MikeMcQuaid
Copy link
Member

Passing on this because I'd like to get brew cask-tests so it doesn't require caskroom to be tapped and this is going in the opposite direction.

@reitermarkus reitermarkus deleted the test-bot-cask-container-dependencies branch April 5, 2017 21:11
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants