-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-bot: Install dependencies for Cask container tests. #747
test-bot: Install dependencies for Cask container tests. #747
Conversation
Longer-term we need to figure out a way of testing these things that doesn't require additional dependencies being installed on our bots (like Unfortunately the |
8bd555c
to
ba8d79f
Compare
I completely agree, however, I don't see a way to test the correct detection and extraction of containers without having the tools to extract them installed. I think we can neglect at least |
Sounds like a good argument to 💀 that code 😉. |
test "brew", "cask", "install", "https://raw.githubusercontent.com/caskroom/homebrew-cask/master/Casks/adobe-air.rb" | ||
test "brew", "install", "https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/cabextract.rb" | ||
test "brew", "install", "https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/unar.rb" | ||
test "brew", "install", "https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/xz.rb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be enough to have these installed systemwide on the build machines? This means they would likely not be kept particularly up-to-date but might be nicer than sticking them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's possible, yes, as long as they can extract the containers I don't care if they are up-to-date.
ba8d79f
to
2506c22
Compare
2506c22
to
39d07a2
Compare
Passing on this because I'd like to get |
brew tests
with your changes locally?In preparation of #725,
adobe-air
cabextract
unar
andxz
have to be installed before running
brew cask-tests
, otherwise some of the container tests will be skipped.