Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cask dependency resolution. #6668

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Oct 31, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolve both cask and formula dependencies at the same time in order to handle the case where a cask depends on a formula which in turn depends on a cask.

Fixes Homebrew/homebrew-cask#71771.

@reitermarkus reitermarkus requested a review from a team October 31, 2019 19:37
@reitermarkus reitermarkus merged commit 2c383b5 into Homebrew:master Nov 1, 2019
@reitermarkus reitermarkus deleted the cask-deps branch November 1, 2019 15:59
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brew Cask dependency order when both Cask and Formula dependencies used.
2 participants