Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python_virtualenv_constants: upgrade virtualenv to 16.4.0 #5697

Merged
merged 1 commit into from
Feb 9, 2019

Conversation

lembacon
Copy link
Member

@lembacon lembacon commented Feb 9, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@lembacon lembacon merged commit 7ce517c into Homebrew:master Feb 9, 2019
@lembacon lembacon deleted the virtualenv-16.4.0 branch February 9, 2019 19:44
@iMichka
Copy link
Member

iMichka commented Feb 11, 2019

Looks like upstream let a big bug slip through: pypa/setuptools#1652
I have already 2 packages on linuxbrew that do not build anymore.

Is there a way to:

  • patch setuptools in homebrew?
  • revert this change?

@lock lock bot added the outdated PR was locked due to age label Mar 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants