Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18849 : fix duplicate casks when symlinks exist #18946

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

vidishanevatia
Copy link

@vidishanevatia vidishanevatia commented Dec 17, 2024

When a cask is renamed (e.g. logi-options-plus to logi-options+), Homebrew creates a symlink in the Caskroom directory. Currently, brew list --cask shows both the original and symlinked cask as separate entries. This patch modifies the listing logic to resolve symlinks and show only unique casks.

Fixes #18849

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When a cask is renamed (e.g. logi-options-plus to logi-options+),
Homebrew creates a symlink in the Caskroom directory. Currently,
`brew list --cask` shows both the original and symlinked cask as
separate entries. This patch modifies the listing logic to resolve
symlinks and show only unique casks.

Fixes Homebrew#18849
@vidishanevatia vidishanevatia changed the title cmd/list: fix duplicate casks when symlinks exist Fixes #18849 : fix duplicate casks when symlinks exist Dec 17, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @vidishanevatia!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 17, 2024
Merged via the queue into Homebrew:master with commit 6d2a500 Dec 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew list --cask shows symlinks of renamed packages
2 participants