Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace some top-level constants #18914

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Namespace some top-level constants #18914

merged 1 commit into from
Dec 11, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Dec 11, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Just some repo hygiene 🪥

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@dduugg dduugg added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 0bcb764 Dec 11, 2024
28 checks passed
@dduugg dduugg deleted the scope-constants branch December 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants