Remove unsafe references from CLI and Formulary code #18894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Relates to #18777
I cleaned up some unnecessary
unsafe
and active-support-ish code in the CLI, to help with #18847Because of how the code is coupled to
Formulary
, I did the same there as well. I find the resulting code better to follow as well, there was a lot ofoptions
munging to avoidnil
passing. (I think that strategy can be beneficial when used occasionally, but not so much in this specific instance.)