Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafe references from CLI and Formulary code #18894

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Dec 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Relates to #18777

I cleaned up some unnecessary unsafe and active-support-ish code in the CLI, to help with #18847

Because of how the code is coupled to Formulary, I did the same there as well. I find the resulting code better to follow as well, there was a lot of options munging to avoid nil passing. (I think that strategy can be beneficial when used occasionally, but not so much in this specific instance.)

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dduugg dduugg merged commit c1f664d into master Dec 6, 2024
28 checks passed
@dduugg dduugg deleted the unsafe-cleanup branch December 6, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants