-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provides a config option to ignore warnings about Xcode being outdated #18509
Conversation
8cd0d7e
to
5f4a8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit on the fence about this, but I won't block it if other maintainers are fine with it.
HOMEBREW_NO_WARN_OUTDATED_XCODE: { | ||
description: "If set, Homebrew will not warn about using outdated (but still compatible) Xcode versions.", | ||
boolean: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined not to document this at all:
HOMEBREW_NO_WARN_OUTDATED_XCODE: { | |
description: "If set, Homebrew will not warn about using outdated (but still compatible) Xcode versions.", | |
boolean: true, | |
}, |
in which case you should ignore my other suggestion about Homebrew::EnvConfig
(since that relies on the env variable being in env_config.rb
).
I'm 👎 on this. Silencing a legitimate warning because an enterprise is slow to update doesn't make sense to me. |
Co-authored-by: Carlo Cabrera <[email protected]>
Right above this suggested change, there is code to ignore these warnings in github actions. The reason that is wanted in the github actions environment is similar to the reason for this PR – there are environments where you cannot update Xcode the day it comes out and you'd prefer not to have a warning print. It feels like removing the linked code and instead setting |
I don't think we should silence these, they are legitimate warnings and companies being slow to update doesn't stop that. Just like we don't hide the warnings that macOS versions are outdated. |
Just for clarity – I am talking about using a version of Xcode 15 which is not the latest (the latest version of Xcode is 15.4 and was released in May) but was still released less than 1 year ago. I am just asking that the same control of warning messages used for the CI is exposed to normal users. Also – any debugging or support requested from the brew community always includes the ´brew doctor´output, so this warning would be printed there. I went and looked at how older macOS versions are handled by brew. I think there are some differences from this:
|
Worth noting that this warning already should not appear if you are installing from bottles and only when installing from source. I'm assuming you're using a third-party tap that doesn't use bottles? Does your |
Thanks for pointing that out – I was unaware. Yes, we are using our own (internal) tap – most are built from source, mostly because the infra to build/update bottles is a challenge to set up. (None depend_on xcode). They are node, python or go CLIs.
I'm not entirely sure what you mean – it points to the |
Then it's not:
|
Actually the only reason we silence them there is because it's our internal CI system. Sorry, passing on this. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?I'm adding this since in our organization, there are parts of the organization which are slower about updating xcode versions. In our case we are using an older version of Xcode 15 – so, still on an Xcode from this year, just not 15.4. This is because we rely on Simulator visual screenshots and these can sometimes change very slightly between Xcode versions. We want to silence the warning for the users who are updating Xcode in a controlled manner.