formula: fix alias/generic/prepend std_cmake_args issue. #18364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
SMillerDev
approved these changes
Sep 20, 2024
carlocab
approved these changes
Sep 20, 2024
|
Looks like we need #18298 now. |
|
@carlocab good catch, thanks. |
auto-merge was automatically disabled
September 20, 2024 12:00
Pull request was closed
MikeMcQuaid
force-pushed
the
fix_cmake_extend_prepend
branch
from
7743c52 to
d8fd19d
Compare
Seen in: Homebrew/homebrew-core#191090 (comment) There's a missing signature issue here due to the `generic_*` aliasing we're doing. With prepend, though: this is no longer needed and we can use `super` instead which is more idiomatic and nicer overall. This pattern should probably be applied in other places but: let's try this targetting fix for here first.
|
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in Homebrew/homebrew-core#191090 (comment)
There's a missing signature issue here due to the
generic_*aliasing we're doing. With prepend, though: this is no longer needed and we can usesuperinstead which is more idiomatic and nicer overall.This pattern should probably be applied in other places but: let's try this targetting fix for here first.
Regression from #18305
CC @dduugg @carlocab @SMillerDev