-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump more files to Sorbet typed: strict
#18354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @issyl0! A few style suggestions, none blocking.
Sorry for the delay here, I thought the style issues were the only ones. But I'll get around to fixing the actual typechecking failures hopefully tonight! |
5549714
to
9975249
Compare
Sorry, I forgot this still had auto-merge on. Oh well, if it 💥 and I can't fix it ahead of tomorrow's release, then revert? |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?typed: strict
in all (non-package) files in Homebrew organisation #17297.