cask/audit: Rework tmpdir removal #17377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I previously introduced a finalizer method in `Cask::Audit` to remove the created `@tmpdir` once it's no longer needed but the existing approach produces a `finalizer references object to be finalized` warning when `brew audit` is run. I didn't see this warning when I was originally testing it but now it reliably appears. This reworks the finalizer to define it within the `#extract_artifacts` method and use `@tmpdir` as the target object.
3 tasks
MikeMcQuaid
approved these changes
May 27, 2024
|
Thanks for fix @samford. Would appreciate work on a better solution here that avoids the (very non-idiomatic) finaliser use. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?I previously introduced a finalizer method in
Cask::Auditto remove the created@tmpdironce it's no longer needed (#17358) but the existing approach produces afinalizer references object to be finalizedwarning whenbrew auditis run. I didn't see this warning when I was originally testing it but now it reliably appears.This reworks the finalizer to define it within the
#extract_artifactsmethod and use@tmpdiras the target object.Fixes #17374.