extend/kernel: make opoo/odie/etc. print GitHub Actions notes.
#17255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
approved these changes
May 8, 2024
MikeMcQuaid
force-pushed
the
github_actions_opoo_odie
branch
from
368a507 to
cbcf7c1
Compare
carlocab
approved these changes
May 8, 2024
Merged
MikeMcQuaid
force-pushed
the
github_actions_opoo_odie
branch
3 times, most recently
from
9d36269 to
f3a7309
Compare
MikeMcQuaid
force-pushed
the
github_actions_opoo_odie
branch
4 times, most recently
from
bbf360b to
e06ba60
Compare
SMillerDev
reviewed
May 9, 2024
MikeMcQuaid
force-pushed
the
github_actions_opoo_odie
branch
2 times, most recently
from
b9fcdc1 to
27a5558
Compare
carlocab
approved these changes
May 9, 2024
We already do this for deprecations but these may make warnings and errors from Homebrew easier to spot in GitHub Actions logs. While we're here, cleanup other cases that should have used `GitHub::Actions::Annotation` but didn't and provide some helpers and tweaks there necessary for our use case here.
MikeMcQuaid
force-pushed
the
github_actions_opoo_odie
branch
from
27a5558 to
16901a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do this for deprecations but these may make warnings and errors from Homebrew easier to spot in GitHub Actions logs.
Maybe we only want to do this for warnings or maybe only for deprecations 🤷🏻. Feedback welcome.