Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/pkgconfig: merge pc files for 11.1 and 11.0 #10129

Merged
merged 3 commits into from
Dec 28, 2020
Merged

os/mac/pkgconfig: merge pc files for 11.1 and 11.0 #10129

merged 3 commits into from
Dec 28, 2020

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 24, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
    • this returns an error about returning a valid JAVA_HOME
  • Have you successfully run brew man locally and committed any changes?

Closes #10126.

This combines the pc files for Big Sur 11.0 and 11.1. We no longer distinguish between minor versions of Big Sur in the CLT since #10072.

Merge this before #10150.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-25 at 07:35:58 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 24, 2020
@carlocab carlocab marked this pull request as draft December 24, 2020 08:03
@carlocab carlocab marked this pull request as ready for review December 24, 2020 12:48
@MikeMcQuaid
Copy link
Member

Thanks for this @carlocab!

@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 25, 2020
@MikeMcQuaid
Copy link
Member

Thanks @carlocab!

@carlocab
Copy link
Member Author

No, thank you, @MikeMcQuaid. I've been a Homebrew user for such a long time it's a little shocking how long it took me to start contributing.

@MikeMcQuaid MikeMcQuaid merged commit e74be0f into Homebrew:master Dec 28, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @carlocab!

@carlocab carlocab deleted the big-sur-pkg-config branch December 28, 2020 13:31
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

11.0 and 11.1 pkg-config files should be merged
5 participants