-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Verify more constants are not loaded at startup
Loading different constants can be tricky with all the requires in Homebrew so we want to strengthen the existing checks to make sure that things are not getting required when there is a performance penalty. This expands the existing check to include more constants beyond `Formula` that we don't expect to be defined and that pull in a lot of other dependencies.
- Loading branch information
1 parent
8e08a69
commit dd52b78
Showing
3 changed files
with
35 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16
Library/Homebrew/test/support/helper/cmd/brew-verify-formula-undefined.rb
This file was deleted.
Oops, something went wrong.
33 changes: 33 additions & 0 deletions
33
Library/Homebrew/test/support/helper/cmd/brew-verify-undefined.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# typed: strict | ||
# frozen_string_literal: true | ||
|
||
require "cli/parser" | ||
|
||
UNDEFINED_CONSTANTS = %w[ | ||
Cask::Cask | ||
Formula | ||
Formulary | ||
Homebrew::API | ||
Tap | ||
].freeze | ||
|
||
parser = Homebrew::CLI::Parser.new do | ||
usage_banner <<~EOS | ||
`verify-undefined` | ||
Verifies that the following constants have not been defined | ||
at startup to make sure that startup times stay consistent. | ||
Contants: | ||
#{UNDEFINED_CONSTANTS.join("\n")} | ||
EOS | ||
end | ||
|
||
parser.parse | ||
|
||
UNDEFINED_CONSTANTS.each do |constant_name| | ||
Object.const_get(constant_name) | ||
ofail "#{constant_name} should not be defined at startup" | ||
rescue NameError | ||
# We expect this to error as it should not be defined. | ||
end |