Merge pull request #18808 from Homebrew/feat/cask/block_install

feat: only block cask install on Linux

Library/Homebrew/cask/installer.rb

@@ -280,11 +280,18 @@ def install_artifacts(predecessor: nil)
       end
     end
 
+    sig { void }
     def check_requirements
+      check_stanza_os_requirements
       check_macos_requirements
       check_arch_requirements
     end
 
+    sig { void }
+    def check_stanza_os_requirements
+      nil
+    end
+
     def check_macos_requirements
       return unless @cask.depends_on.macos
       return if @cask.depends_on.macos.satisfied?
@@ -710,3 +717,5 @@ def load_cask_from_source_api!
     end
   end
 end
+
+require "extend/os/cask/installer"

Library/Homebrew/extend/os/cask/installer.rb

@@ -0,0 +1,4 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "extend/os/linux/cask/installer" if OS.linux?

Library/Homebrew/extend/os/linux/cask/installer.rb

@@ -0,0 +1,23 @@
+# typed: strict
+# frozen_string_literal: true
+
+module OS
+  module Linux
+    module Cask
+      module Installer
+        private
+
+        extend T::Helpers
+
+        requires_ancestor { ::Cask::Installer }
+
+        sig { void }
+        def check_stanza_os_requirements
+          raise ::Cask::CaskError, "macOS is required for this software."
+        end
+      end
+    end
+  end
+end
+
+Cask::Installer.prepend(OS::Linux::Cask::Installer)

Library/Homebrew/extend/os/linux/cli/parser.rb

@@ -11,17 +11,9 @@ module Parser
 
         sig { void }
         def set_default_options
-          args.set_arg(:formula?, true)
-        end
+          return if args.only_formula_or_cask == :cask
 
-        sig { void }
-        def validate_options
-          return unless args.respond_to?(:cask?)
-          return unless T.unsafe(self).args.cask?
-
-          # NOTE: We don't raise an error here because we don't want
-          #       to print the help page or a stack trace.
-          odie "Invalid `--cask` usage: Casks do not work on Linux"
+          args.set_arg(:formula?, true)
         end
       end
     end

Library/Homebrew/test/cli/parser_spec.rb

@@ -574,13 +574,6 @@
         end
       end
 
-      it "throws an error when defined" do
-        expect { parser.parse(["--cask"]) }
-          .to output("Error: Invalid `--cask` usage: Casks do not work on Linux\n").to_stderr
-          .and not_to_output.to_stdout
-          .and raise_exception SystemExit
-      end
-
       # Developers want to be able to use `audit` and `bump`
       # commands for formulae and casks on Linux.
       it "succeeds for developer commands" do
@@ -599,18 +592,9 @@
         end
       end
 
-      it "throws an error when --cask defined" do
-        expect { parser.parse(["--cask"]) }
-          .to output("Error: Invalid `--cask` usage: Casks do not work on Linux\n").to_stderr
-          .and not_to_output.to_stdout
-          .and raise_exception SystemExit
-      end
-
       it "throws an error when both defined" do
         expect { parser.parse(["--cask", "--formula"]) }
-          .to output("Error: Invalid `--cask` usage: Casks do not work on Linux\n").to_stderr
-          .and not_to_output.to_stdout
-          .and raise_exception SystemExit
+          .to raise_exception Homebrew::CLI::OptionConflictError
       end
     end
   end
@@ -629,5 +613,13 @@
       args = parser.parse([])
       expect(args.formula?).to be(true)
     end
+
+    it "does not set --formula to true when --cask" do
+      parser = described_class.new(Cmd) do
+        switch "--cask"
+      end
+      args = parser.parse([])
+      expect(args.respond_to?(:formula?)).to be(false)
+    end
   end
 end