Enforce milestones #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mrenderer classes from rendergraph::openglnode
This makes it compatible with Python 3.9 (default on macOS).
…leared up code when creating a waveformsignalrenderer, and appending it as a node
…-shaders rendergraph: use opengl node and add shaders
…item-shortcut Usability/Keyboard: Add a rebindable keyboard shortcut for editing items as a replacement for F2
…ller-setting Remove boilerplate and duplication in controller setting definition
…ockey-2-ie fix: skip message send if sysex code is undefined
(fixup) Overview: use 1.0 if track has no valid replayGain ratio
Added softfix workflow
chore: fix recently introduced clazy warnings
these changes solve a 1st error in pre-commit after changing a qss.
Error like
Traceback (most recent call last):
File "D:\mixxx-git\mixxx\tools\qsscheck.py", line 435, in <module>
sys.exit(main())
^^^^^^
File "D:\mixxx-git\mixxx\tools\qsscheck.py", line 428, in main
for message in check_skins(mixxx_path, skins, args.ignore.split(",")):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\mixxx-git\mixxx\tools\qsscheck.py", line 322, in check_skins
classnames, objectnames = get_global_names(mixxx_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\mixxx-git\mixxx\tools\qsscheck.py", line 252, in get_global_names
objectnames.update(set(RE_UI_OBJNAME.findall(f.read())))
^^^^^^^^
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.2544.0_x64__qbz5n2kfra8p0\Lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 10957: character maps to <undefined>
Co-authored-by: Swiftb0y <[email protected]>
qsscheck.py -> added utf-8 in open()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.